-
Notifications
You must be signed in to change notification settings - Fork 71
[LG-5461] fix(button): onClick
handler type inference
#3060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Size Change: 0 B Total Size: 2.01 MB ℹ️ View Unchanged
|
2145df8
to
a42e5b8
Compare
a42e5b8
to
e3a3c5d
Compare
✍️ Proposed changes
For now, I'm simply adding a failing test for context:
The failing test I added in that PR shows how the argument of callbacks passed to onClick of Button can no longer be inferred (it becomes implicit any), since it switched from
Box
toInferredPolymorphic
(via PR-2695)🎟 Jira ticket: LG-5461
✅ Checklist
For new components
For bug fixes, new features & breaking changes
pnpm changeset
and documented my changes🧪 How to test changes
TBD.